Hi ! > Unicode support is another topic. However I would suggest to accetp > UTF-8 input just like most of other libraries do and convert UTF-8 > inputs to wchar internally. UTF-8 is what is supported and used by > posix systems and developers are familiar with it. Zip file format has multiple approaches to unicode - but I also think utf-8 is best of them. Other approaches better not to discover (for example file name mangling happening in some cases). But for native OS support - char* (utf-8) to wchar_t* conversion still needs to be performed - at least for windows. For linux you need to "enable" utf-8 support. (Again - See unicode_helper_functions.c/h) -- Have a nice day! Tarmo. ----- Original Message ---- From: Pierre Joye <pierre.php%gmail.com@localhost> To: Tarmo Pikaro <tapika%yahoo.com@localhost> Cc: Thomas Klausner <tk%giga.or.at@localhost>; Benjamin Eikel <libzip-mailing-list%eikel.org@localhost>; libzip-discuss%nih.at@localhost Sent: Wed, February 16, 2011 10:28:47 AM Subject: Re: Error message on Windows: Renaming temporary file failed: File exists hi, Unicode support is another topic. However I would suggest to accetp UTF-8 input just like most of other libraries do and convert UTF-8 inputs to wchar internally. UTF-8 is what is supported and used by posix systems and developers are familiar with it. On Tue, Feb 15, 2011 at 7:59 PM, Tarmo Pikaro <tapika%yahoo.com@localhost> wrote: > Hi ! > > Please check through my wrappers - file_system_access\. > Currently I have made them from unicode perspective (See > base_include\unicode_helper_functions.c) > > - I would prefer to switch to that library completely - after that we don't > necessarily need to > detect which function is present or not - windows_file_system_access.c is > included for windows, > similar kind for linux. > > No #ifdef mess anymore. > > Only thing which I could think of to improve - is to replace > unicode_helper_functions.h/c with > portable os indepedent unicode conversion functions - I can provide you them as > well - > made once upon a time with additional test code as well. > > For now I don't need unicode support from libzip, but later on in future I >will, > and I will help you > to intergate unicode support. (Already done this in another zip library). > -- > Have a nice day! > Tarmo. > > > > ----- Original Message ---- > From: Pierre Joye <pierre.php%gmail.com@localhost> > To: Thomas Klausner <tk%giga.or.at@localhost> > Cc: Benjamin Eikel <libzip-mailing-list%eikel.org@localhost>; > libzip-discuss%nih.at@localhost > Sent: Mon, February 14, 2011 11:10:48 AM > Subject: Re: Error message on Windows: Renaming temporary file failed: File > exists > > hi Thomas, > > As far as I can see HAVE_MOVEFILEEXA is defined cmake-config.h and > MoveFileExA is correctly used to define _zip_rename. So I suppose it > is fixed already. I can test a windows build later today. > > Cheers, > > On Sun, Feb 13, 2011 at 5:15 PM, Thomas Klausner <tk%giga.or.at@localhost> > wrote: >> On Thu, Oct 07, 2010 at 11:05:31AM +0200, Pierre Joye wrote: >>> MoveFileEx does not exist but MoveFileExA or MoveFileExW. There are >>> aliases available which point to the ansi or wildchar version, >>> depending on the Unicode mode. This function is also available since >>> windows 2000, I would simply add HAVE_MOVEFILEEXA and say that windows >>> 2000 or later is required (or even go with XPSP2 or maybe even SP3). >> >> I'm unsure what, if anything, needs to be fixed in libzip for >> this. Suggestions? >> Thomas >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > > > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
Made by MHonArc.